Fixed the bug where selecting one side automatically selected the other side as well#87
Merged
Merged
Conversation
wojiangkuanglong
changed the title
There was a problem hiding this comment.
Pull request overview
Adjusts text-selection behavior in the DiffViewer so selecting text on one side doesn’t also select content on the opposite side.
Changes:
- On
onMouseDown, clears any priornoSelectstate and appliesnoSelectonly to the opposite side (leftvsright). - Removes the previous
onMouseUpcleanup logic (replaced with a no-op handler).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+817
to
+820
| const rightElements = document.getElementsByClassName("right"); | ||
| for (let i = 0; i < rightElements.length; i++) { | ||
| rightElements.item(i).classList.remove(this.styles.noSelect); | ||
| } |
Comment on lines
+825
to
+829
| const opposite = document.getElementsByClassName( | ||
| prefix === LineNumberPrefix.LEFT ? "right" : "left", | ||
| ); | ||
| for (let i = 0; i < elements.length; i++) { | ||
| const element = elements.item(i); | ||
| element.classList.add(this.styles.noSelect); | ||
| for (let i = 0; i < opposite.length; i++) { | ||
| opposite.item(i).classList.add(this.styles.noSelect); |
| element.classList.remove(this.styles.noSelect); | ||
| } | ||
| }} | ||
| onMouseUp={() => {}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before：
after：
